microbiomedata / nmdc-server

Data portal client and server for NMDC.
https://data.microbiomedata.org
Other
9 stars 0 forks source link

improved interface for clicking on the upset plot #1044

Closed aclum closed 1 month ago

aclum commented 1 year ago

During the workshop today we discovered it is difficult to select data that has metagenomes AND metaproteomics . The bar chart in the upset plot is too small (n=17) to click on and the faceted search is an OR selection. Can we make the bar + number for each row in the upset chart clickable

cc @emileyfadrosh

aclum commented 5 months ago

This came up during DP user research.

cc @ljohnson09

aclum commented 5 months ago

To be discussed with kitware but I think the easiest solution would be to also make the numbers links. @marySalvi @naglepuff please weigh in here.

aclum commented 5 months ago

Screenshot 2024-04-17 at 4 52 02 PM In the screenshot the bar chart with a corresponding number of 33 is the lowest bar chart I can click on.

aclum commented 1 month ago

Action is to make whole rectangular area, including the number clickable.

ssarrafan commented 1 month ago

Discussed at infra sync meeting today. Alicia would like this issue broken out into two different issues. This specific issue will be for expanding the clickable area of the upset plot to include the numbers and not just the bar chart so that it will be easier to click even if the bar chart is too thin to work. The second issue will be to allow specifying and/or operator for omics type faceted search. See https://github.com/microbiomedata/nmdc-server/issues/1335

ssarrafan commented 1 month ago

@marySalvi do you think you can finish this today before the release? Or should we move this to the next sprint?

marySalvi commented 1 month ago

@marySalvi do you think you can finish this today before the release? Or should we move this to the next sprint?

@ssarrafan I don't think it would be reviewed in time to be fully completed today. I'll move it to next sprint.

aclum commented 1 month ago

looks good on dev!