Closed pkalita-lbl closed 3 weeks ago
Okay addressing @marySalvi's comments:
100%
is a better option than auto
. That was the reason that the header row was being scrolled out of view in the video you posted. I guess I missed that because...height
and width
settings on the Handsontable instance need to be set after every template update. I forgot that DataHarmonizer resets a bunch of Handsontable properties -- including height
-- after you change templates. That's why the header would stay stuck at the top after changing tabs.overflow: auto
on #harmonizer-root
is actually superfluous so it can be removed.Just to make the intention of these changes more clear, the green box should be the only thing on the page that scrolls. Everything else on the page should be fixed. If any other element scrolls or if you ever get more than one set of scrollbars something is wrong.
Tested in dev. Looks fixed! When should I expect to see the fix in prod?
Fixes https://github.com/microbiomedata/issues/issues/701
Testing instructions
Details
Previously we set a fixed height directly on the element (
#harmonizer-root
) where the DataHarmonizer instance is mounted. This was a bit janky because the362px
offset is a bit too brittle to changes in surrounding elements and it doesn't interact well with DataHarmonizer's (sort of odd) choice to have the height of its Handsontable instance be75vh
. So these changes:75vh
choice by telling the Handsontable instance to have a width and height setting ofauto
.v-app-bar
-- both controlled by the same variable.This also fixes the minor annoyance that when the red validation result box appears it doesn't push the row with the color key and submit button slightly off the bottom of the page.