microbiomedata / nmdc-server

Data portal client and server for NMDC.
https://data.microbiomedata.org
Other
9 stars 0 forks source link

Fix DataHarmonizer scrolling issue #1267

Closed pkalita-lbl closed 3 weeks ago

pkalita-lbl commented 1 month ago

Fixes https://github.com/microbiomedata/issues/issues/701

Testing instructions

Details

Previously we set a fixed height directly on the element (#harmonizer-root) where the DataHarmonizer instance is mounted. This was a bit janky because the 362px offset is a bit too brittle to changes in surrounding elements and it doesn't interact well with DataHarmonizer's (sort of odd) choice to have the height of its Handsontable instance be 75vh. So these changes:

This also fixes the minor annoyance that when the red validation result box appears it doesn't push the row with the color key and submit button slightly off the bottom of the page.

pkalita-lbl commented 4 weeks ago

Okay addressing @marySalvi's comments:

Just to make the intention of these changes more clear, the green box should be the only thing on the page that scrolls. Everything else on the page should be fixed. If any other element scrolls or if you ever get more than one set of scrollbars something is wrong.

image

mslarae13 commented 3 weeks ago

Tested in dev. Looks fixed! When should I expect to see the fix in prod?

pkalita-lbl commented 3 weeks ago

June 24