microbiomedata / nmdc-server

Data portal client and server for NMDC.
https://data.microbiomedata.org
Other
9 stars 0 forks source link

Rename `expires` to `expires_in` in TokenResponse #1287

Closed pkalita-lbl closed 1 week ago

pkalita-lbl commented 1 week ago

This came up in the discussion of an nmdc-runtime PR (https://github.com/microbiomedata/nmdc-runtime/pull/572). Even though we're not claiming to be a full OAuth 2.0-compatible authorization server, I had intended to remain close to the standard where possible. I think it was just an oversight that I had used expires instead of the recommended expires_in as a field in the TokenResponse class.

Nothing in the front-end actually uses that value, so I think this is a fairly low-risk change. But I'd rather change it now before it hits production for the first time.