search

microbiomedata / nmdc-server

Data portal client and server for NMDC.
https://data.microbiomedata.org
Other
8 stars 0 forks source link

Redis hostname is hard-coded (unnecessarily constrains deployment) #1301

Open eecavanna opened 2 months ago

eecavanna commented 2 months ago

The hostname, redis, is hard-coded in the source code. For example:

https://github.com/microbiomedata/nmdc-server/blob/5ad07cc6dfe62bce258b44a6a64f05e8ac2e44e7/Dockerfile.worker#L14

Having hard-coded hostnames puts constraints on the deployment environment (including on other things deployed to the same environment). In this case, this project is claiming (i.e. reserving) the hostname redis for the Redis instance it uses.

I propose allowing the host name to be configurable via an environment variable.

eecavanna commented 2 months ago

The same may be true (TBD) for the hostnames, backend and data.