search

microbiomedata / nmdc-server

Data portal client and server for NMDC.
https://data.microbiomedata.org
Other
9 stars 0 forks source link

Make ORCID Base URL configurable via environment variable #1348

Closed eecavanna closed 1 month ago

eecavanna commented 1 month ago

In this branch, I made it so the backend would get the ORCID Base URL from an environment variable. This will allow developers to configure the backend to use the sandbox ORCID environment vs. the production ORCID environment.

This comment is what prompted me to implement this change.

Note: The changes in this PR were originally made with respect to the berkeley-schema-migration branch. Based upon some feedback in #1341, I have created this new branch in which the same changes have been made with respect to the main branch. Once this PR gets merged into main, I will close PR #1341 (and—instead—to a main-to-berkeley-schema-migration merge in order to "get these same changes" to exist in the berkeley-schema-migration branch).

eecavanna commented 1 month ago

I will merge this branch in without review because the changes are the same (aside from surrounding a value with double quotes in a .env file) as those that were already reviewed in #1341.