Add ability to select multiple sample type environment

microbiomedata / nmdc-server

Data portal client and server for NMDC.

https://data.microbiomedata.org

Other

9 stars 0 forks source link

Add ability to select multiple sample type environment #1367

Open mslarae13 opened 3 months ago

mslarae13 commented 3 months ago

Currently, NMDC submission portal has a radio button to select only 1 type of sample (soil, water, sediment, etc)

We'd like this to be checkboxes and all for 1 study to have multiple sample types in 1 submission.

IF submitting for JGI and EMSL, all the sample types will need to populate the JGI and EMSL tabs the same way the single sample does
Need to make sure the sample type is populated for each sample when the ingest to mongo happens
Can we update Environmental Packages to Environmental Extensions to accurately match GSC

mslarae13 commented 3 months ago

@naglepuff @pkalita-lbl @shreddd @jeffbaumes

mslarae13 commented 3 months ago

To satisfy

https://github.com/microbiomedata/issues/issues/513

ssarrafan commented 3 months ago

Assigning to @marySalvi for next sprint per the meeting with Emiley, Alicia and Chris today.

mslarae13 commented 3 months ago

@marySalvi feel free to move this issue to the correct repo!

ssarrafan commented 2 months ago

Discussed at infra sync and it's more complicated that expected. @marySalvi still working on this.

pkalita-lbl commented 2 months ago

The proposed changes will require changes in the Field Notes app. Cross-linking that issue here: https://github.com/microbiomedata/nmdc-field-notes/issues/177

mslarae13 commented 2 months ago

Work will be complete by end of September to satisfy milestone. Roll out to production will NOT happen with September roll out. Roll out can happen in October, updates to the app should be done in time.

mslarae13 commented 2 months ago

Will NOT be part of

https://github.com/microbiomedata/issues/issues/874

ssarrafan commented 2 months ago

Moving to next sprint per updates by @mslarae13 thank you

ssarrafan commented 1 month ago

Will this issue be completed this sprint? @marySalvi @mslarae13

marySalvi commented 1 month ago

Will this issue be completed this sprint? @marySalvi @mslarae13

Yes, it should be

mslarae13 commented 1 month ago

Decision today at infrastructure sync: will not merge until after berkeley-schema is in production, so after oct 15. There will be merge conflicts

ssarrafan commented 1 month ago

@marySalvi @mslarae13 so can this be considered done (for DOE report purposes) but moved to the next sprint for production deployment? Or is it not quite done yet?

marySalvi commented 1 month ago

I think this can be considered done but should not be merged until after Oct 15th

mslarae13 commented 1 month ago

Ready to merge?

mslarae13 commented 1 month ago

@marySalvi @pkalita-lbl Any updates here? I believe the PR noted that if this is merged it'll break the app.

pkalita-lbl commented 1 month ago

No no no, I would like this to be merged into main sooner than later so that I can complete some app updates.

marySalvi commented 1 month ago

No no no, I would like this to be merged into main sooner than later so that I can complete some app updates.

I have rebased my runtime code and created the PR below. https://github.com/microbiomedata/nmdc-runtime/pull/741

I'll work on rebasing my PR on nmdc-server now. Once both are ready we should be able to merge.

@pkalita-lbl for the runtime PR I adjusted the tests and everything is passing. I would feel more comfortable if I saw the finished products in the DB but I didn't see any test entries in the DB. Am I right in thinking they get deleted in cleanup?

mslarae13 commented 4 weeks ago

Blocked. Coordinating changes in run-time. Major change in the way sample data is stored. Run time translates submission data into mongo. Mary has started working on this.

mslarae13 commented 3 weeks ago

@marySalvi status on this?

mslarae13 commented 3 weeks ago

@marySalvi is addressing a bug in runtime. Correct me if that's wrong