microbiomedata / nmdc_automation

Prototype automation
2 stars 2 forks source link

nom updates not writing to identifiers file #138

Closed aclum closed 4 months ago

aclum commented 4 months ago

This is a minor issue, documenting but not likely worth fixing. I noticed that nom activity identifiers are getting re-mint instead of using identifiers minted from previous rounds of testing when I was testing this locally.

suspected root cause: update_nom_analysis_activity functions in nmdc_automation/re_iding/base.py is missing updated_record_identifiers.add

aclum commented 4 months ago

Closing as deprecated, current code forces new IDs for NOM and metabolomics. cc @mbthornton-lbl