microbiomedata / nmdc_notebooks

Jupyter Notebooks demonstrating R and Python-based access to NMDC metadata and data
Creative Commons Zero v1.0 Universal
5 stars 0 forks source link

Update API calls in NOM visualizations to reflect Berkeley schema #80

Closed samobermiller closed 1 month ago

samobermiller commented 1 month ago

PR updating API calls in NOM visualizations to Berkeley schema. https://github.com/microbiomedata/issues/issues/726

All Submissions:

Notebook Fix Submissions:

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

kheal commented 1 month ago

Nice job @samobermiller and @bmeluch. I found a few references to "omics processing" that should be "data generation", but the functionality looks great.

samobermiller commented 1 month ago

These make sense! I guess in the back of my head I was thinking theyre still technically omics records, but I see thats its confusing cause we query data generation

brynnz22 commented 1 month ago

I think Katherine and I must have reviewed at the same time. I had similar comments.