microbiomedata / sample-annotator

NMDC Sample Annotator
https://microbiomedata.github.io/sample-annotator/static/intro.html
5 stars 9 forks source link

Should portal submitter be included in Study instances? #109

Open turbomam opened 2 years ago

turbomam commented 2 years ago

"submitter" = the person who entered the metadata about a study and its biosamples into the NMDC submission portal

This question is most (or only?) relevant if the submitter didn't included themselves in the contributor/credit modeling

turbomam commented 2 years ago

Real world relevance: sometimes we need to look for samples and studies submitted by Julia Kelliher, etc.

The submissions from the metadata_submission endpoint include a author section

      "author": {
        "id": "36234d1b-043b-4828-a8bc-506b6bc1fdcb",
        "orcid": "0000-0003-4100-9119",
        "name": "Julia Kelliher",
        "is_admin": false
      }

It would be nice to retain that in NMDC JSON/YAML files and in MongoDB.

I'm not sure where to capture the "author"/submitter except by adding another credit association

turbomam commented 2 years ago

Maybe using the Project administration value? See https://microbiomedata.github.io/nmdc-schema/credit_enum/

mslarae13 commented 2 years ago

@turbomam that link gives me error 404. But, I agree, we should retain submitter if they don't include themselves in the credit roles. OR we add some flavor text in the submission portal that says "If you, the submitter, are not the PI, please include your self here as a contributor". But we would need to add a non-credit role of "submitter" to be clear that they did the thing & I don't know that we'd want to do that. Maybe add a checkbox in the "contributors" section that says " ✅: Is submitter" that they check by their name?