search

microbiomedata / sheets_and_friends

Enhance a LinkML model with imported and optionally modified slots
0 stars 0 forks source link

deal with non-string serialization validations #116

Closed turbomam closed 1 year ago

turbomam commented 2 years ago

like minimums, maximums, data types?

sujaypatil96 commented 2 years ago

If you look within the linkml-datastructure branch, specifically at this code block: https://github.com/cidgoh/DataHarmonizer/blob/linkml-datastructure/script/main_linkml.js#L975-L1091, you'll see that Damion already has logic within main_linkml.js to handle when it sees schema ranges that we have in our spreadsheet. I wonder if we need to add any additional logic for handing ranges?

turbomam commented 2 years ago

great. I think this may related to some other issue. I'll try to link them up later today

turbomam commented 2 years ago

@ssarrafan : @sujaypatil96 makes a good point about existing minimum and maximum support in DataHarmonizer. I have an accounting of all of the other slot attributes we provide in sheets_and_friends, and whether they are addressed in DataHarmioizer yet. I'll look at that tomorrow or Thursday.

turbomam commented 1 year ago

@ssarrafan I created a repo called dh_testing that makes it easy to test the degree to which DH supports LinkML language features.

It looks like there is indeed support for most of the the slots that could reasonably be used for documentation and validation. In other words, much more than validating against string_serializations. _Actually, what I was calling validation against string_serialization is really being handled by pattern and structuredpattern.

I will be adding issues to dh_testing to document DH support for some LinkML features that