search

microbiomedata / sheets_and_friends

Enhance a LinkML model with imported and optionally modified slots
0 stars 0 forks source link

Enable EnvO triad dropdowns for soil package #118

Closed pvangay closed 1 year ago

pvangay commented 2 years ago

Previously, the soil templates supported dropdowns for the EnvO triad terms. These values were subsets of EnvO that were most appropriate for the environment (soil), and allowed the user to type in and search for terms within the dropdown. Currently, these drop downs are no longer available in the soil templates. Suggestion: enable dropdowns for templates that have subsets available (currently, soil only).

See this DH link for reference (admin privileges required) image (6)

mslarae13 commented 1 year ago

I recommend this be reassigned to @pkalita-lbl to ensure the drop downs work in the new DH template with the tab view... thoughts? @turbomam

pkalita-lbl commented 1 year ago

This isn't really related to the tab view work. I suspect this is something that needs to be fixed in the process that generates the submission schema.

turbomam commented 1 year ago

I suspect this is something that needs to be fixed in the process that generates the submission schema.

That's mostly true.

We have some curation to support this task in Sheet sheets-for-nmdc-submission-schema, tab envo_terms_for_mixs_env_triad

the sheets_and_friends Makefile does have a rule that takes envo_terms_for_mixs_env_triad as input, but I really need to revisit what's going on there.

Presumably we want more curated EnvO terms for more environmental packages. I have no idea at this point where I got the content in envo_terms_for_mixs_env_triad.

mslarae13 commented 1 year ago

environmental triad drop downs are present in soil Still need drop downs for the other extensions https://github.com/microbiomedata/issues/issues/79 Need a more automated way of identifying what terms should be used for which MIxS extensions

I will make tickets and link here

mslarae13 commented 1 year ago

The soil drop downs work in -dev. Regardless of template / data types.

In -sandbox (likely prod too), the drop downs do NOT work when you have not selected JGI or EMSL, OR when you select any of the OTHER data types.

In -sandbox, the drop downs DO work when you select metaG, metaT, metaP, metaB, NOM, and any combination of ONLY user facility options

@pkalita-lbl , @turbomam , is it safe to say, since these work in -dev, when we push to -prod they will keep working & we can close this ticket?

pkalita-lbl commented 1 year ago

is it safe to say, since these work in -dev, when we push to -prod they will keep working & we can close this ticket?

Yes

ssarrafan commented 1 year ago

Closing this issue based on @pkalita-lbl last comment