search

microbiomedata / sheets_and_friends

Enhance a LinkML model with imported and optionally modified slots
0 stars 0 forks source link

Soil Reference page no longer available #119

Closed pvangay closed 2 years ago

pvangay commented 2 years ago

image

Clicking on "Soil Reference" button opens a new window pointing to this URL, which shows the following error page:

image

Need to figure out who can help fix this.

FYI: @subdavis @turbomam

pkalita-lbl commented 2 years ago

I can take a look

turbomam commented 2 years ago

Pajau (she/her) I’m seeing that the reference HTML link is broken. since @subdavis also reported this, I presume this might be a problem further upstream? do you want me to create an issue in sheets and friends?

@turbomam Yeah, I have a bad feeling it's just not supported in DH yet. I'm not sure what the best short term solution is.

I think the issue here is that the tempalte generation code used to operate over a single tempalte at a. time and create a single reference HTML. Now it operates over a single input at a time, and can define multiple templates from the multiple classes in a LinkML file. It can also be run incrementally, adding templates after the fact.

So @damion asked whether there should be one reference HTML per template (probably) or one per LinkML input.

ddooley commented 2 years ago

Right #304 fixes this by making reference guide auto-generated from schema rather than as a static .html file. I just merged the fix to that as well so this should be resolved with latest linkml-datastructure branch.

pkalita-lbl commented 2 years ago

With this commit https://github.com/microbiomedata/nmdc-server/commit/892b7e7ea0d5ac94f40d6cff5b611792f198389c the new auto-generated reference pages are being used in the NMDC portal. I think we're ready to close this one.