search

microbiomedata / sheets_and_friends

Enhance a LinkML model with imported and optionally modified slots
0 stars 0 forks source link

Typo in geographic location (latitude and longitude) pattern hint #139

Closed pvangay closed 1 year ago

pvangay commented 2 years ago

Currently is: (lat lon} Should be: {lat lon}

(reported by a Champion)

turbomam commented 2 years ago

Where does(lat lon} appear?

turbomam commented 2 years ago

modifications_long

pvangay commented 2 years ago

image

I'm currently in the built environment template (example project)

mslarae13 commented 1 year ago

This is correct in the src schema files. @turbomam where is this error at? Can you fix it?

mslarae13 commented 1 year ago

Backlog until pattern hint (generated from string_serialization) is re-established

mslarae13 commented 1 year ago

Error occurs in sheets_and_friends

I've corrected this in my working version of the sheet. See here: https://docs.google.com/spreadsheets/d/1Qc5dTdo39mNeMrE-WwVSz6SpjL0SiQ8vFfMrBF97804/edit#gid=928747012&range=2:2

When code freeze and schema sync is complete this should be merged into the 'official' sheet.

ssarrafan commented 1 year ago

I'll move this to the next sprint to be merged in. FYI @mslarae13

ssarrafan commented 1 year ago

@mslarae13 @turbomam was this merged? Can this issue be closed?

mslarae13 commented 1 year ago

It wasn't merged. Waiting for the schema freeze to end This should probably go into "in review"

ssarrafan commented 1 year ago

@pkalita-lbl @turbomam does this actually need to be reviewed by anyone still? It's been sitting here for 2 weeks.

pkalita-lbl commented 1 year ago

This one is suffering from extreme issue rot. I don't really know what the whole history is, and I'm not quite sure why I got added to the assignees. But I verified underlying bug has been fixed ({lat lon} is there instead of (lat lon}) by inspecting the schema. However you can't see the fix in the interface because of https://github.com/microbiomedata/sheets_and_friends/issues/170. Regardless I think it's time to close this one.