search

microbiomedata / sheets_and_friends

Enhance a LinkML model with imported and optionally modified slots
0 stars 0 forks source link

Updated source_mat_id on submission portal #157

Closed mslarae13 closed 1 year ago

mslarae13 commented 2 years ago

I've updated the description & guidance for source_mat_id.

See: https://docs.google.com/spreadsheets/d/1cMlPKgjZh-v21aMYCm9x1TxzE5BwGQptBQcvuaYAtC8/edit#gid=1241218612 Row 77, 78, 79

In accordance with https://github.com/microbiomedata/nmdc-schema/issues/372 feedback.

Updates need added to data harmonizer and the submission portal.

mslarae13 commented 1 year ago

Adding to SubPort squad. I think this is done? Need to confirm.

turbomam commented 1 year ago

This issue mentions the following issue with closed status:

But neither this issue or the linked issue mention a PR. If there was a merged PR, that's usually strong grounds to close all linked issues. But we'll have do some manual double checking in this case.

mslarae13 commented 1 year ago

Did a quick check! Looks like I edited the linked google sheet https://docs.google.com/spreadsheets/d/1cMlPKgjZh-v21aMYCm9x1TxzE5BwGQptBQcvuaYAtC8/edit?usp=sharing

But made no changes to the schema. I can go ahead and make a branch for this and update it in the schema.

mslarae13 commented 1 year ago

https://github.com/microbiomedata/nmdc-schema/pull/683