microbiomedata / sheets_and_friends

Enhance a LinkML model with imported and optionally modified slots
0 stars 0 forks source link

dna_cont_well pattern isn't being enforced #159

Open turbomam opened 1 year ago

turbomam commented 1 year ago

cc @mslarae13

It looks like all of the user facility slots are being defined in sheet sheets-for-nmdc-submission-schema, tab mixin_slots

That means that the updates we did directly in the nmdc-schema won't be propagated. I think the in-sheet (as opposed to in-schema) definition may be required because tab dh_interfaces associates the jgi_mg_mixin with class soil_emsl_jgi_mg_mt, and tab mixins associates slot dna_cont_well with jgi_mg_mixin. All of that happens before terms are imported from external schemas, including the nmdc-schema.

I will have to experiment more

turbomam commented 1 year ago

dna_cont_well validation is working in soil_emsl_jgi_mg_mt now

turbomam commented 1 year ago

now need to apply that same fix to all slots that were defined in the mixins tab, for all of the templates that use them