Closed pkalita-lbl closed 5 months ago
I tested a submission in dev & it isn't validating. Should this be live in dev & testable? @pkalita-lbl
@mslarae13 can you please describe what you tried to do and the way in which it failed?
Here's where we are right now:
✅ These changes made to sheets_and_friends
✅ New version of sheets_and_friends
released
✅ New version of sheets_and_friends
used in submission-schema
build
✅ New version of submission-schema
released
🚫 Bring new version of submission-schema
into nmdc-server
I was working on that last step on Tuesday when Eric ran into issues bringing the latest schema version into nmdc-runtime
. I put a pause on what I was doing in case there needed to be a new nmdc-schema
version released.
Ok! Thanks @pkalita-lbl can you let me know when this is in dev then? I think the schema issue was resolved???
Yes I can let you know
Required for https://github.com/microbiomedata/issues/issues/718, but keeping that issue open until the actual
submission-schema
changes are made.Summary
The main thing these changes aim to do is provide support for a line like this in the modifications TSV file, where the target of the
replace_attribute
action is a nested path:While I was at it I took the opportunity to a little overdue refactoring and testing.
Details
dict
, keyed on the action name. While processing each row of the modification TSV, the appropriate action handler is retrieved from this map and called.replace_attribute
action to accept nested paths. When one is encountered it builds out the necessary intermediate structures in theschema_dict
before setting thevalue
. See inline comments for more details. I also fixed a bug in this handler where strings were not being cast into booleans correctly.remove_attribute
.main
.poetry-dynamic-versioning
setup