microbiomedata / sheets_and_friends

Enhance a LinkML model with imported and optionally modified slots
0 stars 0 forks source link

Allow nested target paths in replace_attribute action #180

Closed pkalita-lbl closed 5 months ago

pkalita-lbl commented 6 months ago

Required for https://github.com/microbiomedata/issues/issues/718, but keeping that issue open until the actual submission-schema changes are made.

Summary

The main thing these changes aim to do is provide support for a line like this in the modifications TSV file, where the target of the replace_attribute action is a nested path:

class slot action target value
SoilInterface env_local_scale replace_attribute any_of.0.range EnvLocalScaleSoilEnum

While I was at it I took the opportunity to a little overdue refactoring and testing.

Details

mslarae13 commented 5 months ago

I tested a submission in dev & it isn't validating. Should this be live in dev & testable? @pkalita-lbl

turbomam commented 5 months ago

@mslarae13 can you please describe what you tried to do and the way in which it failed?

pkalita-lbl commented 5 months ago

Here's where we are right now:

✅ These changes made to sheets_and_friends ✅ New version of sheets_and_friends released ✅ New version of sheets_and_friends used in submission-schema build ✅ New version of submission-schema released 🚫 Bring new version of submission-schema into nmdc-server

I was working on that last step on Tuesday when Eric ran into issues bringing the latest schema version into nmdc-runtime. I put a pause on what I was doing in case there needed to be a new nmdc-schema version released.

mslarae13 commented 5 months ago

Ok! Thanks @pkalita-lbl can you let me know when this is in dev then? I think the schema issue was resolved???

pkalita-lbl commented 5 months ago

Yes I can let you know