Could we drop the parenthetical portion of the cur_land_use permissible values?

[turbomam]

I have code that ignores the parenthetical portion when mapping to EnvO terms, but even displaying them in the DH pulldowns is awkward

• badlands
• cities
• conifers (e.g. pine,spruce,fir,cypress)
• crop trees (nuts,fruit,christmas trees,nursery trees)
• farmstead
• gravel
• hardwoods (e.g. oak,hickory,elm,aspen)
• hayland
• horticultural plants (e.g. tulips)
• industrial areas
• intermixed hardwood and conifers
• marshlands (grass,sedges,rushes)
• meadows (grasses,alfalfa,fescue,bromegrass,timothy)
• mines/quarries
• mudflats
• oil waste areas
• pastureland (grasslands used for livestock grazing)
• permanent snow or ice
• rainforest (evergreen forest receiving >406 cm annual rainfall)
• rangeland
• roads/railroads
• rock
• row crops
• saline seeps
• salt flats
• sand
• shrub crops (blueberries,nursery ornamentals,filberts)
• shrub land (e.g. mesquite,sage-brush,creosote bush,shrub oak,eucalyptus)
• small grains
• successional shrub land (tree saplings,hazels,sumacs,chokecherry,shrub dogwoods,blackberries)
• swamp (permanent or semi-permanent water body dominated by woody plants)
• tropical (e.g. mangrove,palms)
• tundra (mosses,lichens)
• vegetable crops
• vine crops (grapes)

[mslarae13]

I'm good with it. Maybe put the text that's in the () in the display hint? However, I believe we're currently using EXACTLY what MIxS says is appropriate. I'd like to hear @cmungall 's thoughts on how to convey that we are technically diverging from MIxS here if we do.

@turbomam let me know if you need anything else from me

[turbomam]

Maybe put the text that's in the () in the display hint?

Excellent

I'd like to hear @cmungall 's thoughts on how to convey that we are technically diverging from MIxS here if we do.

@cmungall and I discussed this informally in the past and he didn't explicitly object. But yes, it would be good to get explicit sign-off. I would move any column for a slot whose permissible values were changed into the MiXS (modified) section, but that wouldn't make it explicit that the permissible values in the enumeration have been changed.

I also intend to raise this as an issue with GSC.

[turbomam]

2023-05-18: yes, remove the parenthetical portions form the PV texts

put the parenthetical examples as annotations on the permissible values

[turbomam]

I am going to do this manually now and make an issue for a better approach in the future. See

• https://github.com/microbiomedata/issues/issues/247

[turbomam]

The PV are not asserted in schemasheets/tsv_in/enums.tsv

They are inherited via

local/with_shuttles.yaml: local/from_schemasheets.yaml \
sheets_and_friends/tsv_in/import_slots_regardless.tsv
        $(RUN) do_shuttle \
            --config_tsv  $(word 2,$^) \
            --recipient_model $(word 1,$^) \
            --yaml_output $@.raw

[ssarrafan]

@turbomam does this mean this issue is done (manually) and can be closed?

[turbomam]

Re https://github.com/microbiomedata/sheets_and_friends/issues/60#issuecomment-1555288503

No, still in progress

[turbomam]

The nmdc-schema build process does customize the cur_land_use_enum now.

That has been propagated to the submission-schema ...

... and can be seen in the 'current land use' column in the submission schema playground

I think @pkalita-lbl and I have to make releases of those two schemas and hand that work off to the Submission Portal people. In the long run, we have been talking bout having more automation with respect to that build/release/handoff process.

[turbomam]

Note that since the examples (like 'pine') have been broken out of the permissible value names (like conifers), they aren't exposed in DataHarmoizer now. We have help pop-ups for slots, but not for individual permissible values.

[ssarrafan]

Based on recent comments assuming this is active, moving to new sprint. @turbomam

[ssarrafan]

This GH issue is over 1 year old. @turbomam does this question still need to be answered? What's the goal for this issue?

[mslarae13]

@turbomam is the only thing left to go here to get this into prod on the submission portal?

@pkalita-lbl ?

[pkalita-lbl]

The updated schema is on dev. Is there an expectation that we modify existing submissions in the portal to match the new values? So, for example, if an in-progress submission uses "crop trees (nuts,fruit,christmas trees,nursery trees)", change it to "crop trees" for them?

[mslarae13]

@pkalita-lbl good question! Will keeping it as "crop trees (nuts,fruit,christmas trees,nursery trees)" validate? cause issues downstream / with database transforming and sharing?

[pkalita-lbl]

No, without writing a migration once the new version of the submission schema is brought into the portal old submissions with "crop trees (nuts,fruit,christmas trees,nursery trees)" in them already will not validate anymore. It could potentially confuse the submission-portal-to-Mongo pipeline, but we wouldn't run that on a submission that doesn't validate in the first place.

Since the migration logic is quite straightforward (replace these old values with these new values) in this case I'll go ahead and include it when I bring the latest submission schema into the portal.

[pkalita-lbl]

This is moving through the system as part of https://github.com/microbiomedata/nmdc-server/pull/992

[ssarrafan]

Closing this based on @pkalita-lbl last comment.
Backlog cleanup 12-2023