Make JGIMtInterface Sample Data

[brynnz22]

I have started making JGIMtInterface Sample Data. @turbomam Is it okay if I work off the same branch we used for the plant-assoc data? I started to add to that one :/, so we would keep the same pull request #100 ? Or can I update the name of the pull request to reference the JGIMInterface class and we'll pause on the plant class until we get to that one (see my comment in issue #99).

[turbomam]

It sounds like you're making great progress, so you can forge ahead on this multi-topic branch this time. Thanks for asking.

Here's a summary of the nmdc-schema issue/branch/PR best practices. Many of us deviate a little from time to time, but still strive to follow this pattern:

• create an issue that expresses one problem or limitation and proposes one solution
• create a branch with that issue's number in it, like issue-100-plant-assoc-examples
  • some people accuse me of making branch names too lang
• make changes in the branch that address the issue in general
• make small commits with specific messages like 'plant assoc missing id'
  • ideally, only commit source files, not files that might have been generated by and build/test steps you tried
• after your first commit, make a PR with a # mention of the issue
  • revise the PR name to match the issue if necessary
  • you can put the PR in draft status if you want
  • assign reviewers when ready
• ask questions any time
• speak freely about any changes you'd like to make to this workflow!

[brynnz22]

Thank you @turbomam for outlining this! I am wondering if it is okay if I make several commits before generating a pull request? I was thinking for this particular project, if I generate a PR per commit (I tend to commit after each new yaml file I create), then it might result in a whole lot of PRs. I was thinking one issue per class I am working on, and one PR per issue/class? Would this work?

Also, for the fourth point you make, should I not be committing the project.Makefile with the new lines I create to test a new yaml file? I should only be committing the sample data yaml files?

[turbomam]

Well, the usual idea is that one issue = one branch = one commit. Maybe we need to rethink that in your case. I'll just trust you to organize your own work for now. In the unlikely case that we have trouble finding an organization that we're both happy with, we could ask @pkalita-lbl for a third opinion.

Yes, please check your modified project.Makefile in with the examples data files. Soon I will be showing you a way to check all of the valid and invalid file with a single command, but we should stick with your implementation until then.