search

microbiomedata / submission-schema

https://microbiomedata.github.io/submission-schema/
MIT License
1 stars 1 forks source link

add jgi-mg-interaface sample data files #125

Closed brynnz22 closed 1 year ago

brynnz22 commented 1 year ago

For issue #114 : @turbomam @mslarae13 I added the jgi-mg-interface sample data files. There was one unexpected pass for the dna_sample_name slot. I was able to add a colon in it when it should only allow "a-z, A-Z, 0-9, - and _".

turbomam commented 1 year ago

...dna_sample_name ... I was able to add a colon in it when it should only allow "a-z, A-Z, 0-9, - and _".

Thanks for the PR, @brynnz22 . I'm going to merge it now.

Can you say how you determined that dna_sample_name should only allow a-z, A-Z, 0-9, - and _? Is that in one of our schemas and I just missed it?! Or are you referring to a specification from some other source, like JGI? If that's the case, could you share the JGI specification, preferably in a computable format?