search

microbiomedata / submission-schema

https://microbiomedata.github.io/submission-schema/
MIT License
1 stars 1 forks source link

tube/plate/well validation rules are not working #127

Closed turbomam closed 4 months ago

turbomam commented 1 year ago

examples have been moved to the unexpected_pass directory

I think this was working at one point and I suspect that we can get it working agin

see also

mslarae13 commented 6 months ago

Regex for plate position not working. the problem with the regex is that the negative lookahead needs to include the end-of-string marker as well. The correct regex is: ^(?!A1$|A12$|H1$|H12$)(([A-H][1-9])|([A-H]1[0-2]))$

A10 won't validate and B01 won't validate... B1 and B01 should be valid.

mslarae13 commented 5 months ago

See submission c41dfeac-102e-43b2-adae-6a67f25791f0 for an example .. a lot of the well values aren't validating @pkalita-lbl

mslarae13 commented 4 months ago

@pkalita-lbl @turbomam Is this fixed in dev? So ingest to prod is still needed?

pkalita-lbl commented 4 months ago

Is this fixed in dev?

I believe so but you should test and verify

So ingest to prod is still needed?

Not sure what ingest has anything to do with it? You mean deploy to production? If so, yes, whatever is on dev will go to production with the next release. It's not an change-by-change thing.

mslarae13 commented 3 months ago

Resolved and in prod with most recent ingest.