microbiomedata / submission-schema

https://microbiomedata.github.io/submission-schema/
MIT License
1 stars 1 forks source link

pattern restriction on environmental factor #141

Open aclum opened 1 year ago

aclum commented 1 year ago

In reviewing a recent submission from a user 'environmental factor' doesn't have a pattern match enforced. The text description says this should be formatted like time series design [EFO:EFO_0001779], however the submission validated with a value for environmental factor of 'antibiotic treatment'.

submission schema confirms range is currently no pattern defined for this slot, at least for the host associated interface. https://microbiomedata.github.io/submission-schema/HostAssociatedInterface/

@mslarae13 to confirm that this should be considered a bug

mslarae13 commented 1 year ago

yeah, we need stricter validation here. These should be ontology terms... I think we can make this a global validation across all packages. @pkalita-lbl

mslarae13 commented 5 months ago

Relates to #189