search

microbiomedata / submission-schema

https://microbiomedata.github.io/submission-schema/
MIT License
1 stars 1 forks source link

Create `PoreWaterInterface` class #159

Open bmeluch opened 9 months ago

bmeluch commented 9 months ago

Part of https://github.com/microbiomedata/issues/issues/417.

EMSL includes "pore water" as a category for sample submission, which the NMDC submission schema does not support. MIxS does not have a specific "pore water" extension. Maybe a submission schema class can be assembled out of our existing "soil" and "water" slots?

bmeluch commented 8 months ago

@mslarae13 based on https://github.com/microbiomedata/issues/issues/417#issuecomment-1791588341 should I close this? or mark it as VERY backlogged pending MIxS package?

turbomam commented 8 months ago

BTW: if there was going to be some pore_water modeling, wouldn't it be a new slot and not a new class?

bmeluch commented 8 months ago

If I'm understanding the submission schema correctly (which it is possible that I am not), pore water would be a new sample type which would mean a new submission schema interface class pulling in (mostly) existing schema slots.

turbomam commented 8 months ago

Oh, you mean something like PoreWaterInterface, along the same lines as SoilInterface?

Yes, that would be a class. Good point.

mslarae13 commented 7 months ago

@bmeluch

@mslarae13 based on https://github.com/microbiomedata/issues/issues/417#issuecomment-1791588341 should I close this? or mark it as VERY backlogged pending MIxS package?

Yes. Will wait for GSC pore water extension