Closed mslarae13 closed 7 months ago
@cmungall I added mappings to the term map file linked above. (GLBRC metadata terms / column headers are mapped to NMDC slots here) ... can you look at the mapping levels I selected. I've never done this & want to be sure I am doing it right.
@pkalita-lbl you should have everything you need now. Let me know. if you don't!
@pkalita-lbl what's the status of this issue? Active? Backlog?
End of sprint update:
AH
) as either g/m3
or kPa
(this is driven by external configuration -- not code -- so this doesn't need to hold up the PR)Moving to next sprint.
Adina clarified units. And I updated a unit to match UCUM.
Adina clarified units. And I updated a unit to match UCUM.
Thanks @mslarae13 FYI @pkalita-lbl
So I think where we're at now:
Cel
instead of Celsius
).Next steps:
standard way of representing non-standard things. 🙃
Thank @pkalita-lbl
Updates:
u[E]/m2/s
. This is not strictly UCUM-compliant, but there is no UCUM-compliant way to express that unit. UCUM uses square brackets to denote what they call "arbitrary units" (generally non-SI stuff), but the UCUM spec still enumerates the allowed arbitrary units (Einstein is not one of them). The square brackets are also sort of a warning sign that the unit cannot be automatically converted to another unit. So lacking any better options I went with [E]
to represent the Einstein because it's what UCUM would probably include if it included the Einstein (see issue linked in previous comment).nmdc-server
changes have been made to update the ingest code to accommodate Study
class changes. Kitware is working on that.I'm going to close this issue now. There's nothing else specific to the GLBRC submission that needs to be done. That data is in Mongo on dev and prod. It will show up on the data portal in with the next ingest, which will happen once the changes in https://github.com/microbiomedata/nmdc-server/pull/1084 propagate through.
Ingest the GLBRC metadata submission on NMDC submission portal to mongo and data portal
NMDC submission portal submission ID: d32b5eb6-71e8-4c98-8a57-3e64d05718b4
Notes about this submission
study_category = research_study
funding statement = Support for this research was provided by the Great Lakes Bioenergy Research Center, U.S. Department of Energy, Office of Science, Office of Biological and Environmental Research (Awards DE-SC0018409 and DE-FC02-07ER64494), by the National Science Foundation Long-term Ecological Research Program (DEB 1832042) at the Kellogg Biological Station, and by Michigan State University AgBioResearch.
PI image can be found![IMG_6611](https://github.com/microbiomedata/submission-schema/assets/44581429/d9434bbf-679e-41ee-ab68-57849bb791aa)
All metadata is available Ingested_2023-11_nmdc_sample_metadata.xlsx (This has what is in the submission portal & the metadata that was not in the submission)
GLBRC metadata terms / column headers are mapped to NMDC slots here
TBD