microbiomedata / submission-schema

https://microbiomedata.github.io/submission-schema/
MIT License
1 stars 1 forks source link

Update submission schema so that hardcoded list of classes can be removed from `nmdc-server` #186

Open pkalita-lbl opened 4 months ago

pkalita-lbl commented 4 months ago

Currently nmdc-server maintains a hardcoded list of classes along with meta-information like display names and display statuses: https://github.com/microbiomedata/nmdc-server/blob/ccd899bf07baae6abac7049a20202d6908c72c60/web/src/views/SubmissionPortal/harmonizerApi.ts#L60 There isn't any reason why this information couldn't be derived from the schema directly with some updates. In particular:

mslarae13 commented 2 months ago

@pkalita-lbl what is the submission-schema action? Do we need to add aliases? Or is this really a serve action? "Update server ingest code to leverage NMDC submission schema.

pkalita-lbl commented 2 months ago

what is the submission-schema action?

The bullet points represent things that should be done in the submission schema (update title and descriptions, add annotations).

Do we need to add aliases?

I don't think so.

Or is this really a serve action?

Once this work is complete in the submission schema there is code that can be removed and/or simplified in nmdc-server, but that's a separate step.