search

microbiomedata / submission-schema

https://microbiomedata.github.io/submission-schema/
MIT License
1 stars 1 forks source link

Ensure all values listed in `examples` for a slot actually pass validation #227

Open pkalita-lbl opened 1 month ago

pkalita-lbl commented 1 month ago

In https://github.com/microbiomedata/nmdc-field-notes/issues/184, it was pointed out that there are a number of values listed as examples for some slots which do not conform to the validation rules of the slot itself. I manually confirmed that these slots have invalid examples:

I didn't check every slot so there very well may be more.

This task is to:

1) repair or remove the current invalid examples 2) develop a test in this repo that validates all of the example values and ensure that the build & release process fails if this test fails

turbomam commented 1 month ago

It would be great if we could make this general enough to be used in totally separate repos

turbomam commented 1 week ago

see also

pkalita-lbl commented 6 days ago

This is in progress. A list of examples from submission-schema which do not pass validation has been prepared and set to Mark and Montana for review. Once that review is complete work will resume on either fixing the examples or changing slot definitions to make the existing examples validate.