microbiomedata / submission-schema

https://microbiomedata.github.io/submission-schema/
MIT License
1 stars 1 forks source link

lingering steps for water and soil example data #42

Open turbomam opened 1 year ago

turbomam commented 1 year ago

Remember, ideally the invalid examples would only have one invalid aspect, so they could be fixed and then would pass.

Are we going to keep all of these? What are they good for?

turbomam commented 1 year ago

This "error" is expected and desired

! poetry run check-jsonschema \
    --schemafile project/jsonschema/nmdc_submission_schema.schema.json \
    src/data/invalid/SampleData-water-data-alkalinity-list.yaml

Schema validation errors were encountered. src/data/invalid/SampleData-water-data-alkalinity-list.yaml::$.water_data[0].alkalinity: ['50 milligram per liter', '100 spoons per bucket'] is not of type 'string'

turbomam commented 1 year ago

WARNING:root:No namespace defined for URI: https://microbiomedata/schema/ammonium_nitrogen WARNING:root:No namespace defined for URI: https://microbiomedata/schema/ecosystem WARNING:root:No namespace defined for URI: https://microbiomedata/schema/ecosystem_category WARNING:root:No namespace defined for URI: https://microbiomedata/schema/ecosystem_subtype WARNING:root:No namespace defined for URI: https://microbiomedata/schema/ecosystem_type WARNING:root:No namespace defined for URI: https://microbiomedata/schema/lbc_thirty WARNING:root:No namespace defined for URI: https://microbiomedata/schema/lbceq WARNING:root:No namespace defined for URI: https://microbiomedata/schema/manganese WARNING:root:No namespace defined for URI: https://microbiomedata/schema/nitrate_nitrogen WARNING:root:No namespace defined for URI: https://microbiomedata/schema/nitrite_nitrogen WARNING:root:No namespace defined for URI: https://microbiomedata/schema/specific_ecosystem WARNING:root:No namespace defined for URI: https://microbiomedata/schema/zinc


WARNING:root:Not implemented: slot WARNING:root:There is no established path to nmdc_submission_schema - compile_python may or may not work

turbomam commented 1 year ago

src/data/valid/SampleData-soil-data-exhaustive.yaml:

#    horizon_meth: xxx
#    micro_biomass_C_meth: xxx
#    micro_biomass_N_meth: xxx
#    microbial_biomass_C: 111 units
#    microbial_biomass_N: 111 units

#    oxy_stat_samp: aerobe
#    rel_to_oxygen: aerobe
turbomam commented 1 year ago

src/data/valid/SampleData-water-data-exhaustive.yaml

#    oxy_stat_samp: anaerobe
turbomam commented 1 year ago

Examine local/slot_usage.tsv

turbomam commented 1 year ago
  RelToOxygenEnum:
    permissible_values:
      aerobe:
      anaerobe:
      facultative:
      microaerophilic:
      microanaerobe:
      obligate aerobe:
      obligate anaerobe:

use rel_to_oxygen_enum for both of these, globally and in all slot_usages

  rel_to_oxygen_enum:
    permissible_values:
      aerobe:
      anaerobe:
      facultative:
      microaerophilic:
      microanaerobe:
      obligate aerobe:
      obligate anaerobe:

  oxy_stat_samp_enum:
    permissible_values:
      aerobic:
      anaerobic:
      other:
turbomam commented 1 year ago

These just need to be all-lower-cased! Thanks @pkalita-lbl

#    micro_biomass_C_meth: xxx
#    micro_biomass_N_meth: xxx
#    microbial_biomass_C: 111 units
#    microbial_biomass_N: 111 units
turbomam commented 1 year ago

multi-valued titles:

How are MIxS triad and GOLD pull-downs getting created?

Which are really MIxS, MIxS modified etc.

What help is displayed

Time and date formats

Time zone assumption/validation/labeling

mslarae13 commented 5 months ago

@turbomam is the outstanding task here to just update example files?

Is this in the schema or submission-schema?