microbiomedata / submission-schema

https://microbiomedata.github.io/submission-schema/
MIT License
1 stars 1 forks source link

Too much indentation for the EnvBroadScaleSoilEnum PVs etc #82

Closed turbomam closed 3 months ago

turbomam commented 1 year ago
  EnvBroadScaleSoilEnum:
    name: EnvBroadScaleSoilEnum
    description: placeholder enum descr, DO NOT SORT
    from_schema: https://example.com/nmdc_submission_schema
    permissible_values:
      ________________mediterranean savanna biome [ENVO:01000229]:
        text: ________________mediterranean savanna biome [ENVO:01000229]
turbomam commented 1 year ago

The MIxS/EnvO PVs/menus are built off-line with project.Makefile targets like local/terrestrial_biome_pvs.txt

Changing the amount of indentation could be added in src/nmdc_submission_schema/datamodel/oak_tree_to_pv_list.py

Since the menus are built offline, they will have to be pasted back into schemasheets/tsv_in/enums.tsv

If that could be automated, let's do that too.

Either way, make all would have to be run after changing the indentation level

mslarae13 commented 1 year ago

@turbomam Screen Shot 2023-04-07 at 1 17 58 PM

Some of the biomes are appearing twice

mslarae13 commented 1 year ago

2 things making this happen

We should add new assertions into the envo ontology that identify what broad scale (env triad terms) are applicable for the specific packages

This issue is about appearance and display.. but the maintenance of the list needs taken care of as well. Issue is how the list is built

Display issue: stalled until usability research is done

How the lists are curated: work in the mean time

mslarae13 commented 1 year ago

need example files of things that are obviously right (uses drop down) but things not in the drop down Add ridiculous limitations from a robot perspective.

pkalita-lbl commented 1 year ago

See also: https://github.com/microbiomedata/issues/issues/80 for work on curating the list

mslarae13 commented 1 year ago

This issue being about appearance and display, the usability research will be completed in a 'next' squad. @pkalita-lbl @turbomam from your perspective, is there anything on this issue that can be done until the usability research is complete? (reminder, usability research is asking.. are the __ confusing or helpful? Do you find the tree view useful?)

pkalita-lbl commented 1 year ago

I think there's still an open question of how best to curate the list of permissible values (regardless of whether they're shown with underscores or not). I don't know if there's another issue for that or if we want to repurpose this one.

mslarae13 commented 1 year ago

Revisit when subport v2 squad starts

I think there's still an open question of how best to curate the list of permissible values (regardless of whether they're shown with underscores or not). I don't know if there's another issue for that or if we want to repurpose this one.

See also: https://github.com/microbiomedata/issues/issues/80 for work on curating the list

ssarrafan commented 1 year ago

Based on Montana's last comment I'll remove from sprint and add backlog label. @mslarae13

mslarae13 commented 3 months ago

This issue is resolved __ 4 underscores vs 2 has been solved

Closing, but need to visit less manual management.