search

microbit-foundation / DAPLink

This DAPLink fork is only for development - everything is submitted upstream - please file issues on https://github.com/ARMmbed/DAPLink
Apache License 2.0
9 stars 2 forks source link

Comparison issues #9

Closed MarianSavchuk closed 3 years ago

MarianSavchuk commented 3 years ago

@gerargz, I just noticed that these two comparisons are always false. https://github.com/microbit-foundation/DAPLink/blob/44a2522d35038eb51f04b363a6bb4ff437e46467/source/daplink/interface/swd_host.c#L1070 https://github.com/microbit-foundation/DAPLink/blob/44a2522d35038eb51f04b363a6bb4ff437e46467/source/daplink/interface/swd_host.c#L1081 Is this how it should be or is it a typo?

microbit-carlos commented 3 years ago

Thanks for the report @MarianSavchuk, and great catch! This has been addressed upstream in PR https://github.com/ARMmbed/DAPLink/pull/853, which has been already merged there 🎉