Closed github-actions[bot] closed 3 years ago
Links fixed in https://github.com/microbit-foundation/dev-docs/commit/16f1c90fbb790ef8b9552e5008aba08b912f29c4
Apart from
ERROR https://os.mbed.com/teams/microbit/code/microbit_presenter/
Timeout
ERROR https://www.lancaster.ac.uk/news/articles/2016/lancaster-university-helps-bbc-get-kids-coding/
Lookup www.lancaster.ac.uk on 168.63.129.16:53: server misbehaving
Which shouldn't error, so worth checking after the next report
Lancaster link still errors in https://github.com/microbit-foundation/dev-docs/issues/234
Lookup throws this error
https://www.lancaster.ac.uk/news/articles/2016/lancaster-university-helps-bbc-get-kids-coding/ -> The operation couldn’t be completed. (kCFErrorDomainCFNetwork error 2.)
The link works though. What should we do here to prevent it failing the link checker @microbit-matt-hillsdon?
Looks like they haven't failed in more recent runs.
There's no retry option, sadly: https://github.com/raviqqe/liche/issues/36
If it's a recurring problem we could implement it, then see if we can get the action updated?
There is a timeout option but it's at 30s which seems reasonable.
If those specific links fail repeatedly we could add them to the regex ignore. If it's a more general issue with reliability then retries make more sense. It will never be perfect but worth trying to reduce the noise if it's frequent.
Hmm, though poking around in the HTTP library (fasthttp) that liche uses, it should retry GET requests 5 times by default, which makes the failures a bit more surprising. No backoff is used so far as I can tell.
I've updated the Mbed link that were causing issues, but the Lancaster article link is persistently failing. I think we should just add it to the regex. What do you think?
https://github.com/microbit-foundation/dev-docs/pull/246 appears to have solved the issue, no report today so closing
Link Checker
Errors were reported while checking the connectivity of links.