microbit-foundation / microbit-android

micro:bit official Android application code. The application is free to download from https://play.google.com/store/apps/details?id=com.samsung.microbit
Apache License 2.0
13 stars 10 forks source link

Tell the user that they must always enter 'bluetooth mode' to flash a micro:bit #2

Closed dnlbaines closed 5 years ago

dnlbaines commented 5 years ago

This commit adds a new dialog that prompts the user to enter bluetooth mode when flashing the micro:bit if they have not done so already (and the hex they are using requires it). It also changes the samples.zip extraction to a much faster method.

Minor changes:

microbit-sam commented 5 years ago

Hey Daniel,

Can you remind me of the steps required to trigger the warning you've added?

I thought we were catching the scenario where user has reflashed the micro:bit and hasn't repaired, but I've not managed to trigger your pop up.. flashing worked from 'makecode app' mode

dnlbaines commented 5 years ago

Hey Daniel,

Can you remind me of the steps required to trigger the warning you've added?

I thought we were catching the scenario where user has reflashed the micro:bit and hasn't repaired, but I've not managed to trigger your pop up.. flashing worked from 'makecode app' mode

It should trigger if you have previously paired the micro:bit in the app but haven't entered bluetooth mode when you try to flash (and the hex is not one that does not require you to enter bluetooth mode).

microbit-sam commented 5 years ago

Right, so I think this also wants to cover when you try to connect to a micro:bit that you've flashed over USB since pairing

I've just tried USB flashing, pairing, USB flashing, then connecting in app mode This fails with Error: Please reset your micro:bit and try again

In this situation the micro:bit needs to be re-paired, as the USB flash has removed the bond info that was stored in the flash