search

microbit-foundation / microbit-android

micro:bit official Android application code. The application is free to download from https://play.google.com/store/apps/details?id=com.samsung.microbit
Apache License 2.0
13 stars 10 forks source link

Relabel and arrange menu items #55

Closed microbit-grace closed 2 months ago

microbit-grace commented 3 months ago

Task: https://microbit-global.monday.com/boards/1162890768/pulses/1457889927

Update menu items ordering so that it is more like the iOS app:

martinwork commented 3 months ago

@microbit-grace @jaustin

I already did this in my branch with the new flash-pair flow https://github.com/martinwork/microbit-android/tree/new-flash-pair-flow

I wondered if "Manage Connections" might be too long as a page tile on some phones, and if it was was unnecessarily grand for Pair. The iOS app supports more than one pairing and removing a connection.

It all looks good, so I am happy for you to merge, and I'll fix up my branch.

microbit-grace commented 3 months ago

I wondered if "Manage Connections" might be too long as a page tile on some phones, and if it was was unnecessarily grand for Pair. The iOS app supports more than one pairing and removing a connection.

Interesting point, I have forwarded the message to Lucy to see what she thinks on Monday.com 😄

Edit: Jonny agreed to use "Pair". I will change to use "Pair" https://github.com/microbit-foundation/microbit-android/pull/55/commits/bd8b863819f475789a4c7599b7035a54b97a1347

microbit-grace commented 3 months ago

Thanks @martinwork, I have reverted the change from "Manage Connections" to "Pair and copied your change from your new flash flow PR so that the header in the My Programs page is also updated to not show "Flash"

martinwork commented 3 months ago

Oh yes @microbit-grace, I had forgotten about needing to make that change. Beware... I seem to remember one or two of those strings were reused in not-really-related places... or maybe it was just that there were two strings for Flash.

microbit-grace commented 3 months ago

@martinwork Yes, I noticed that there were confusingly another "Flash" string, but I think that's for the Flash button.

I have also changed the landscape main activity button styling to have textAllCaps: false (https://github.com/microbit-foundation/microbit-android/pull/55/commits/55a9d393be218c3646dd08efc5bda9e5d8d97f19). If we want all the other buttons to not be fully capitalised, I think I might do it in a separate PR. If you are happy with changes, I shall squash and merge. Many thanks!

microbit-matt-hillsdon commented 2 months ago

Closing in favour of #63.