Open gary-atkinson opened 3 years ago
@gary-atkinson does the version number on the getting started page need bumping too? it appears to still be "Version 1.2.0"
Not sure where this is configured, but found it in this line https://github.com/microbit-foundation/microbit-swift-playgrounds/blob/master/Intro%20to%20microbit/Contents/Chapters/Chapter1.playgroundchapter/Pages/GettingStarted.cutscenepage/PrivateResources/en.lproj/gettingStarted/gettingStarted.hyperesources/gettingstarted_hype_generated_script.js#L78
It should already be bumped to 1.3.0
On 17 May 2021, at 10:25, Mark @.***> wrote:
@gary-atkinson https://github.com/gary-atkinson does the version number on the getting started page need bumping too? it appears to still be "Version 1.2.0"
Not sure where this is configured, but found it in this line https://github.com/microbit-foundation/microbit-swift-playgrounds/blob/master/Intro%20to%20microbit/Contents/Chapters/Chapter1.playgroundchapter/Pages/GettingStarted.cutscenepage/PrivateResources/en.lproj/gettingStarted/gettingStarted.hyperesources/gettingstarted_hype_generated_script.js#L78 https://github.com/microbit-foundation/microbit-swift-playgrounds/blob/master/Intro%20to%20microbit/Contents/Chapters/Chapter1.playgroundchapter/Pages/GettingStarted.cutscenepage/PrivateResources/en.lproj/gettingStarted/gettingStarted.hyperesources/gettingstarted_hype_generated_script.js#L78 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microbit-foundation/microbit-swift-playgrounds/pull/37#issuecomment-842169712, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJO26U3R6KTVQMOUT5C5VCLTODOJDANCNFSM447F44XQ.
@gary-atkinson I sent your build for this out to some users and had positive feedback. I think it's good to merge and release if your happy.
Thanks Mark, I’ll do all the necessary feed updates, zips and merges this evening.
Regards,
Gary
On 29 Sep 2021, at 09:44, Mark @.***> wrote:
@gary-atkinson https://github.com/gary-atkinson I sent your build for this out to some users and had positive feedback. I think it's good to merge and release if your happy.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/microbit-foundation/microbit-swift-playgrounds/pull/37#issuecomment-929967847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJO26U4HTF227V3PBV5G2I3UELGVLANCNFSM447F44XQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Merging changes from v2-support to master
Changes to support pairing with the V2 board and tweaks to the accelerometer setup for the Intro book