Update P9 to be UNUSED on V2 (was shared on V1)

microbit-foundation / micropython-microbit-v2

Temporary home for MicroPython for micro:bit v2 as we stablise it before pushing upstream

MIT License

42 stars 23 forks source link

Update P9 to be UNUSED on V2 (was shared on V1) #64

Closed jaustin closed 3 years ago

jaustin commented 3 years ago

P9 is a spare pin on micro:bit V2, but was shared with the display on V1

Full pinout is available https://tech.microbit.org/hardware/edgeconnector/

See #57

dpgeorge commented 3 years ago

I tested this. When you do display.off() then display.on() again it reclaims pin9. To fix that 2 lines from src/codal_port/microbit_display.c need to be removed (grep for microbit_p9_obj).

Let me know if you want me to make the change.

jaustin commented 3 years ago

Should've grepped-before-PR sorry. Serves me right for trying to use the web interface to fix bugs.

I've made the change and pushed. Will test the CI build when it's ready. @dpgeorge in general you should feel free to just fix and commit things like this of mine if you're already in the right place etc. (Also fine to ask me to fix it, useful to see what I'd missed :) )

dpgeorge commented 3 years ago

I tested this PR and it works. Merged in a94e53de7e7d6856a97b71ad5667501b05e7bf03