search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
57 stars 36 forks source link

Upgrade to CodeMirror 6 release #1016

Closed microbit-robert closed 2 years ago

microbit-robert commented 2 years ago

Closes #995. Closes #753. Closes #697. Closes #612. Closes #716.

github-actions[bot] commented 2 years ago

Preview build will be at https://review-python-editor-v3.microbit.org/upgrade-codemirror/

microbit-robert commented 2 years ago

Leaving as a draft to avoid any accidental merge until we're happy we've tested this enough.

microbit-robert commented 2 years ago

798 remains an issue, so we can raise a CM bug (if we haven't already) once merged.

microbit-matt-hillsdon commented 2 years ago

There's a subtle code structure highlighting behaviour change that I think is worth looking at:

New: image

Old: image

I think you could make a case for this being an improvement!

microbit-matt-hillsdon commented 2 years ago

I spent some more time testing this today and I'm happy.

I'll deal with the conflict and tests for any interactions with #1037 then merge later this evening.