search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
56 stars 37 forks source link

Escape, Tab to tab out of the editor is broken #1048

Closed microbit-matt-hillsdon closed 1 year ago

microbit-matt-hillsdon commented 1 year ago

Escape, Tab to tab out of the editor is broken. We suspect the CodeMirror 6 upgrade. As it's otherwise not possible to tab out we should fix this quickly.

microbit-robert commented 1 year ago

Following the changes made here -> https://github.com/codemirror/view/commit/741bcd3bd13c2067ff586a59e153719d0926c4e1, Escape is handled by our signatureHelp keymap to close signature help, so line 376 is never called, which sets the lastEscPress time.

This is the issue that prompted the change for reference -> https://github.com/codemirror/dev/issues/758