search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
57 stars 36 forks source link

Fix bug if lines don't match when mapping diagnostics #1064

Closed microbit-matt-hillsdon closed 1 year ago

microbit-matt-hillsdon commented 1 year ago

The document may have changed in the meantime so notice when lines don't make sense. I've also added a specific check for the scenario where diagnostics have to < from.

Closes https://github.com/microbit-foundation/python-editor-v3/issues/1062

github-actions[bot] commented 1 year ago

Preview build will be at https://review-python-editor-v3.microbit.org/fix-1062/

microbit-matt-hillsdon commented 1 year ago

Tried point and range diagnostics and all seems to be working well. I don't think it's reasonable to be able to repro this via the UI so we'll have to rely on reviewing the logic of the fix and the tests.

microbit-matt-hillsdon commented 1 year ago

I'll monitor the impact on staging for a bit before releasing this.