search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
56 stars 37 forks source link

Fix early DOM access #1066

Closed microbit-matt-hillsdon closed 1 year ago

microbit-matt-hillsdon commented 1 year ago

I'm not sure if this fix makes sense. In production the main script has the defer attribute which is supposed to wait until after the parse. But I'm not sure what else explains the crashes we see here. Leaving here as a draft to ponder.

github-actions[bot] commented 1 year ago

Preview build will be at https://review-python-editor-v3.microbit.org/no-body-fix/

microbit-matt-hillsdon commented 1 year ago

I also can't repro document.readyState < interactive in a minimal setup (even with a large DOM). I wonder what's going on here.

microbit-matt-hillsdon commented 1 year ago

I think this is based on a misunderstanding. There must be another explanation. Closing.