search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
56 stars 37 forks source link

Signature help fix tweak. #1067

Closed microbit-matt-hillsdon closed 1 year ago

microbit-matt-hillsdon commented 1 year ago

Close the signature help while we know the view is still good. Alternatively we could cancel the timeout but this is OK too. I can't see simple API to check that a view is still good to interact with after an async step.

github-actions[bot] commented 1 year ago

Preview build will be at https://review-python-editor-v3.microbit.org/sig-help-tweak/

microbit-matt-hillsdon commented 1 year ago

We've seen crashes where this dispatch results in CM accessing a contentEditable field that's no longer there. I assume some blur scenario that results in a change of editor but I wasn't able to repro even with a manually added timeout.