search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
54 stars 36 forks source link

GHA production builds determine the stage incorrectly #1092

Closed microbit-matt-hillsdon closed 1 year ago

microbit-matt-hillsdon commented 1 year ago

This release build failed to identify the stage as PRODUCTION and failed at the e2e tests (which it only ran because it had concluded REVIEW):

https://github.com/microbit-foundation/python-editor-v3/actions/runs/3952870807/jobs/6768485487

The logic that switches on ref to determine the stage is wrong, the ref was refs/tags/v3.0.14 for a tag.

Perhaps we can entirely avoid relying on GITHUB_EVENT_NAME in that case?

In any case we need to fix it and then run a 3.0.15 release equivalent to 3.0.14 which did not deploy.

microbit-matt-hillsdon commented 1 year ago

One for the morning.