search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
54 stars 36 forks source link

Fix type error on Node 18/NPM 9.x #1108

Closed microbit-matt-hillsdon closed 1 year ago

microbit-matt-hillsdon commented 1 year ago

I think this should always have been an issue. Not clear why it wasn't previously. Type issue only, not a problem in practice.

github-actions[bot] commented 1 year ago

Preview build will be at https://review-python-editor-v3.microbit.org/fix-type-issue/

microbit-matt-hillsdon commented 1 year ago

e2e is the spurious toast issue we've seen often since the GHA switch. I'll spend some time on it next week. I still don't see how it can happen logically, so we'll have to catch it in the act.