microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
54 stars 36 forks source link

More reliable alert check #1111

Closed microbit-matt-hillsdon closed 1 year ago

microbit-matt-hillsdon commented 1 year ago

Closes https://github.com/microbit-foundation/python-editor-v3/issues/1110

github-actions[bot] commented 1 year ago

Preview build will be at https://review-python-editor-v3.microbit.org/alert-fix/

microbit-matt-hillsdon commented 1 year ago

As I couldn't really reproduce locally we need to see this pass in CI a few times before merge. I still occasionally see an unrelated failure in documentation.test.ts, but at least the open.test.ts cases should pass.