search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
57 stars 37 forks source link

Pyright doesn't work in Safari 13 but everything else seems OK #1146

Closed microbit-matt-hillsdon closed 6 months ago

microbit-matt-hillsdon commented 7 months ago

Testing via browserstack shows that in Safari 13 with the recent sim fixes (on beta/staging only) the app works pretty well except Pyright. This might be an easy fix so worth understanding. Possibly BigInt support? If so that might not be worth fixing.

This is the error that gets reported against the first line of main.py:

An internal error occurred while parsing file "/src/main.py": _tryNumber@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:752703
_handleCharacter@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:748068
_addNextToken@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:745969
tokenize@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:744756
_startNewParse@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:761006
https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:759493
parseSourceFile@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:759467
https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:982269
log@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:463486
_parseFile@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1284843
_bindFile@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1285210
https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1286699
log@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:463486
https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1274876
runWithCancellationToken@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1239007
_runEvaluatorWithCancellationToken@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1302558
Mn@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:461195
_analyzeOneChunk@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1408731
onMessage@https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1405505
https://python.microbit.org/v/beta/workers/pyright-main-46e9f54371eb3b42b37c.worker.js:2:1410404
microbit-matt-hillsdon commented 6 months ago

There are also significant rendering issues with recent versions of Chakra UI so I think this isn't a realistic target for us and Safari 14 is a better baseline for now. Closing.