Video welcome dialog (behind flag)

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3

https://python.microbit.org

MIT License

57 stars 36 forks source link

Closed microbit-robert closed 2 years ago

microbit-robert commented 2 years ago

Adds new dialog for live (video is a placeholder) behind livePreview flag.
Same flag also disabled the black release notice bar (useful for screenshots etc)
Add Feedback button to Help menu

github-actions[bot] commented 2 years ago

Preview builds:

Remember to do localStorage.clear() to see the release dialog again (either flavour).

I've not incremented the dialog version as its shared between the two dialog types. We can do that when we remove the flag.

microbit-robert commented 2 years ago

Things to check/change:

I've copied the YouTube embedding iframe, including the comments as they still seem relevant, from the website. Is this sane?
Is the error handling for loading the video data overkill? Should this data be stored elsewhere so we don't continuously load it on opening the dialog?
There's a line under the video that seems to be a product of the AspectRatio component. Changing the maxWidth on this component to be less than the container seems to remove it. Why?
Update the CMS with the onboarding video data when finished before merging.

microbit-matt-hillsdon commented 2 years ago

I'm happy with this. Can't merge now due to lack of video.

microbit-matt-hillsdon commented 2 years ago

@microbit-robert if we're not getting a video for a while we need to at least merge the strings from this for translation.

Tempted to either produce a very quick video or put the feature behind a flag so we can merge quickly. Let's discuss next week.

microbit-matt-hillsdon commented 2 years ago

Discussed with Lucy and agreed we'll have a stop-gap video for Friday so no need for a flag.