microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
57 stars 36 forks source link

File system dirty check breaks after restore from session storage #840

Closed microbit-matt-hillsdon closed 2 years ago

microbit-matt-hillsdon commented 2 years ago

Repro:

  1. New tab
  2. Edit
  3. Refresh, OK warning
  4. Refresh, note no warning

The dirty state is in-memory only.

This will become important as we're planning to use the same dirty state to avoid showing superfluous warning dialogs when loading files.

microbit-matt-hillsdon commented 2 years ago

You also don't become "clean" by saving a hex so this really isn't suitable at the moment.