Add UI to show/hide simulator.

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3

https://python.microbit.org

MIT License

57 stars 36 forks source link

Add UI to show/hide simulator. #868

Closed microbit-robert closed 2 years ago

github-actions[bot] commented 2 years ago

Preview build will be at https://review-python-editor-next.microbit.org/sim-hide/ https://review-python-editor-next.microbit.org/sim-hide/?flag=simulator

microbit-robert commented 2 years ago

Box shadow is going to be a pain. Could move show/hide buttons into split view divider, but left hand button won't shift position with the header height change on small screens.

microbit-robert commented 2 years ago

Currently lacks box-shadow for left hand divider due to stacking context difficulties and the need to retain hiding the collapse button when search is opened.

microbit-matt-hillsdon commented 2 years ago

Last issue is that you can tab into the collapsed sim from the header: