microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
57 stars 36 forks source link

Set panel focus on link to reference from sim. #898

Closed microbit-robert closed 2 years ago

github-actions[bot] commented 2 years ago

Preview build will be at https://review-python-editor-next.microbit.org/sim-reference-focus/

microbit-matt-hillsdon commented 2 years ago

I gave up on trying to improve this. I really think it could be better but it's too risky for this point.

In particular it would help if tabIndex was derived from tab and sidebar visibility and perhaps if the sidebar/simulator visibility was managed by the router state. Too large a change for this point.

Minor tweak to avoid serializing "focus" in the URL.