search

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3
https://python.microbit.org
MIT License
57 stars 36 forks source link

Fix missing strings. #919

Closed microbit-matt-hillsdon closed 2 years ago

github-actions[bot] commented 2 years ago

Preview build will be at https://review-python-editor-next.microbit.org/sim-press-hold-fix/

microbit-matt-hillsdon commented 2 years ago

CI failure seems unrelated:

FAIL  src/e2e/edits.test.ts (15.474 s)
  ● Browser - edits › prompts on close if file edited

    expect(received).toEqual(expected) // deep equality

    Expected: true
    Received: false

      21 |     await app.findVisibleEditorContents(/A change/);
      22 |
    > 23 |     expect(await app.closePageCheckDialog()).toEqual(true);
         |                                              ^
      24 |   });
      25 |
      26 |   it("prompts on close if project name edited", async () => {

      at Object.<anonymous> (src/e2e/edits.test.ts:23:46)