Ensure focus returns to menu buttons for accessibility purposes

microbit-foundation / python-editor-v3

Micro:bit Educational Foundation Python Editor V3

https://python.microbit.org

MIT License

57 stars 36 forks source link

Ensure focus returns to menu buttons for accessibility purposes #991

Closed microbit-robert closed 2 years ago

microbit-robert commented 2 years ago

Closes #974

github-actions[bot] commented 2 years ago

Preview build will be at https://review-python-editor-v3.microbit.org/menu-accessibility/

microbit-robert commented 2 years ago

The amount of prop and ref passing is extreme, but perhaps unavoidable. The connection helper dialogs make this harder, but I think I've tightened up behaviour here as well.

Todo:

[x] - WebUSB not supported flow.
[x] - Check firmware update flow.

Will need testing to ensure that uncommon cases haven't been missed.