Tidy up old build tools/appraoches

microbit-foundation / standalone-error-program

A small, standalone (No CODAL) bit of code to display errors on the micro:bit, for use in DAPLink and as a template for BLE bootloader

MIT License

0 stars 1 forks source link

Tidy up old build tools/appraoches #6

Closed jaustin closed 4 years ago

jaustin commented 4 years ago

@martinwork the SAEP as it stands is working well for @gerargz - thanks so much

At the moment, we have a bit of history in the repo: the nRF SDK, nRFx, different linker scripts, etc.

Assuming you're happy with the nrfx build,

Could you please remove the nordic SDK stuff
Could you take out build folders that aren't required so we have one clear way to build
Tag a release for Gerardo to use in future builds
Ensure that any steps for making clean binaries with the magic at the end are documented (EG if LTO is required)/scripted

martinwork commented 4 years ago

@gerargz Just to be sure I'm not about to delete it... Which version did you use?

It looks like nrfx_nrf52833_xxaa, the nrfx build with the magic in the binary?

martinwork commented 4 years ago

I have kept that build and created a python build.py to create the header - compared with DAPLink factory_image_v1.47 branch header. The original SDK build and the build with the linker hack to place the code at the end of the binary have gone.

I've added a comment to the makefile as a reminder that using link time optimisation didn't go well.

Tagged previous state as v0.0.1 and new tidy state with build.py as v0.0.2.

gerargz commented 4 years ago

@gerargz Just to be sure I'm not about to delete it... Which version did you use?

It looks like nrfx_nrf52833_xxaa, the nrfx build with the magic in the binary?

Yes @martinwork , I used the nrfx_nrf52833_xxaa.bin with the 0xFACEC0DE magic word. I see now that you have added a script to convert the image to a C header (built/led_error_app.h). I have updated DAPLink to use that C header.