ADC configuration config suggestion...

microbuilder / LPC11U_LPC13U_CodeBase

Open source code base for ARM Cortex M3 LPC1347 or Cortex M0 LPC11U37/LPC11U24 MCUs

Other

55 stars 38 forks source link

ADC configuration config suggestion... #7

Closed ve2yag closed 11 years ago

ve2yag commented 11 years ago

For my project I modify adc.h to select 10-bit and uncomment line in adc.c for to configure pin usage.

I suggest to move #define in board configuration to choose which pin to configure as ADC pin and to choose bit mode. This change will prevent me to change adc.h/adc.c and keep codebase clean as possible...

Thank !!

-Remi

microbuilder commented 11 years ago

Thanks for the feedback. I moved the low power and 10-bit settings to the config file, but pin setup should normally be done in boardInit in my opinion. The changes will make it into the next push.